Amirmahdi/approagency
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: controller reminder

Browse Source
This commit is contained in:
Amirmahdi
2025-12-12 22:15:37 +03:30
parent e998a31339
commit 10567e7a81
1 changed files with 51 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/ReminderController.php
+27 -12
View File
@@ -97,14 +97,15 @@ private function authorizeReminder(Reminder $reminder)
public function packageIndex(PackageName $packageName) public function packageIndex(PackageName $packageName)
{ {
$reminders = Reminder::where('user_id', Auth::id()) // Get package-wide reminders (user_id = null) for this package
->where('package_name_id', $packageName->id) $reminders = Reminder::where('package_name_id', $packageName->id)
->whereNull('user_id')
->orderBy('time') ->orderBy('time')
->get(); ->get();
return response()->json($reminders); return response()->json($reminders);
} }
public function packageStore(Request $request, PackageName $packageName) public function packageStore(Request $request, PackageName $packageName)
{ {
@@ -126,9 +127,16 @@ public function packageStore(Request $request, PackageName $packageName)
return response()->json($reminder, 201); return response()->json($reminder, 201);
} }
public function packageUpdate(Request $request, PackageName $packageName, Reminder $reminder) public function packageUpdate(Request $request, PackageName $packageName, Reminder $reminder)
{ {
$this->authorizeReminder($reminder); // Basic checks
if (!auth()->check()) {
return response()->json(['message' => 'Unauthorized'], 401);
}
if ($reminder->user_id !== null) {
return response()->json(['message' => 'This is not a package-wide reminder'], 400);
}
if ($reminder->package_name_id !== $packageName->id) { if ($reminder->package_name_id !== $packageName->id) {
return response()->json(['message' => 'This reminder does not belong to this package'], 403); return response()->json(['message' => 'This reminder does not belong to this package'], 403);
@@ -146,11 +154,18 @@ public function packageUpdate(Request $request, PackageName $packageName, Remind
$reminder->update($data); $reminder->update($data);
return response()->json($reminder); return response()->json($reminder);
} }
public function packageDestroy(PackageName $packageName, Reminder $reminder) public function packageDestroy(PackageName $packageName, Reminder $reminder)
{ {
$this->authorizeReminder($reminder); // Basic checks
if (!auth()->check()) {
return response()->json(['message' => 'Unauthorized'], 401);
}
if ($reminder->user_id !== null) {
return response()->json(['message' => 'This is not a package-wide reminder'], 400);
}
if ($reminder->package_name_id !== $packageName->id) { if ($reminder->package_name_id !== $packageName->id) {
return response()->json(['message' => 'This reminder does not belong to this package'], 403); return response()->json(['message' => 'This reminder does not belong to this package'], 403);
@@ -159,6 +174,6 @@ public function packageDestroy(PackageName $packageName, Reminder $reminder)
$reminder->delete(); $reminder->delete();
return response()->json(null, 204); return response()->json(null, 204);
} }
} }