fix: controller reminder

This commit is contained in:
2025-12-12 22:15:37 +03:30
parent e998a31339
commit 10567e7a81
+19 -4
View File
@@ -98,8 +98,9 @@ private function authorizeReminder(Reminder $reminder)
public function packageIndex(PackageName $packageName)
{
$reminders = Reminder::where('user_id', Auth::id())
->where('package_name_id', $packageName->id)
// Get package-wide reminders (user_id = null) for this package
$reminders = Reminder::where('package_name_id', $packageName->id)
->whereNull('user_id')
->orderBy('time')
->get();
@@ -128,7 +129,14 @@ public function packageStore(Request $request, PackageName $packageName)
public function packageUpdate(Request $request, PackageName $packageName, Reminder $reminder)
{
$this->authorizeReminder($reminder);
// Basic checks
if (!auth()->check()) {
return response()->json(['message' => 'Unauthorized'], 401);
}
if ($reminder->user_id !== null) {
return response()->json(['message' => 'This is not a package-wide reminder'], 400);
}
if ($reminder->package_name_id !== $packageName->id) {
return response()->json(['message' => 'This reminder does not belong to this package'], 403);
@@ -150,7 +158,14 @@ public function packageUpdate(Request $request, PackageName $packageName, Remind
public function packageDestroy(PackageName $packageName, Reminder $reminder)
{
$this->authorizeReminder($reminder);
// Basic checks
if (!auth()->check()) {
return response()->json(['message' => 'Unauthorized'], 401);
}
if ($reminder->user_id !== null) {
return response()->json(['message' => 'This is not a package-wide reminder'], 400);
}
if ($reminder->package_name_id !== $packageName->id) {
return response()->json(['message' => 'This reminder does not belong to this package'], 403);